This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
========================================
- Coverage 5.05% 5.01% -0.04%
========================================
Files 13 13
Lines 2990 3009 +19
========================================
Hits 151 151
- Misses 2812 2831 +19
Partials 27 27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
gen1us2k
reviewed
Oct 16, 2023
gen1us2k
approved these changes
Oct 17, 2023
recharte
approved these changes
Oct 17, 2023
ghost
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Left a couple comments for clarification.
oksana-grishchenko
added a commit
that referenced
this pull request
Oct 19, 2023
This reverts commit 529d5e8.
oksana-grishchenko
added a commit
that referenced
this pull request
Oct 19, 2023
This reverts commit 9b06d28.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry opt-out for upstream operators
Problem:
EVEREST-504
Everest user needs a way to disable the upstream operators telemetry.
Related pull requests
Cause:
When user opts-out/opts-in the Everest telemetry, they would expect the upstream operators telemetry also be disabled/enabled.
Solution:
Read env variable DISABLE_TELEMETRY and patch the OLM subscription.
The env variable DISABLE_TELEMETRY is expected to be set to disable the telemetry for the the pxc, psmdb, pg operators.
CHECKLIST
Jira
Tests