Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-504 Telemetry opt out #177

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Conversation

oksana-grishchenko
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko commented Oct 16, 2023

Telemetry opt-out for upstream operators

Problem:
EVEREST-504

Everest user needs a way to disable the upstream operators telemetry.

Related pull requests

Cause:
When user opts-out/opts-in the Everest telemetry, they would expect the upstream operators telemetry also be disabled/enabled.

Solution:
Read env variable DISABLE_TELEMETRY and patch the OLM subscription.

The env variable DISABLE_TELEMETRY is expected to be set to disable the telemetry for the the pxc, psmdb, pg operators.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #177 (4230c05) into main (f1f07f6) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #177      +/-   ##
========================================
- Coverage   5.05%   5.01%   -0.04%     
========================================
  Files         13      13              
  Lines       2990    3009      +19     
========================================
  Hits         151     151              
- Misses      2812    2831      +19     
  Partials      27      27              
Files Coverage Δ
pkg/kubernetes/client/client.go 3.28% <0.00%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/kubernetes/client/client.go Show resolved Hide resolved
@oksana-grishchenko oksana-grishchenko marked this pull request as ready for review October 17, 2023 10:08
@oksana-grishchenko oksana-grishchenko requested a review from a user October 17, 2023 10:08
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Left a couple comments for clarification.

pkg/kubernetes/client/client.go Show resolved Hide resolved
pkg/kubernetes/client/client.go Show resolved Hide resolved
@oksana-grishchenko oksana-grishchenko enabled auto-merge (squash) October 17, 2023 14:45
@oksana-grishchenko oksana-grishchenko merged commit 529d5e8 into main Oct 17, 2023
6 of 8 checks passed
@oksana-grishchenko oksana-grishchenko deleted the EVEREST-504-telemetry-opt-out branch October 17, 2023 14:51
oksana-grishchenko added a commit that referenced this pull request Oct 19, 2023
oksana-grishchenko added a commit that referenced this pull request Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants